Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSS101] Task 3: Display OpenDigger labels in the right of the repository header #807 #847

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

399617
Copy link
Contributor

@399617 399617 commented Jul 26, 2024

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues
#807

Details

Thanks to Yantong's help, OpenRank can now be displayed normally in most scenarios.
Background Information: The meta file exported by OpenDigger now includes label data.
Objective: To add this label data to the project page for better display of label information.
Reference: You can refer to the file at https://oss.x-lab.info/open_digger/github/X-lab2017/open-digger/meta.json, which lists all labels for the OpenDigger project.
results:
faa40e3247890240ab9a058db4fbd3c

Checklist

Others

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2024

CLA assistant check
All committers have signed the CLA.

@wangyantong2000
Copy link
Collaborator

wangyantong2000 commented Jul 27, 2024

Thank you for your contribution! Nice work.
But before submitting the code, don't forget to run yarn run prettier.

image

@wangyantong2000
Copy link
Collaborator

Your current code has merge conflicts that haven’t been resolved. Please resolve them and commit the changes.
Like this situation.
image

@wangyantong2000 wangyantong2000 requested a review from wxharry July 28, 2024 12:26
@wangyantong2000
Copy link
Collaborator

Thank you for your contribution! At present, I think this task has been completed and no other issues have been found. LGTM.

Copy link
Collaborator

@wxharry wxharry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done.

@wxharry wxharry merged commit d0dae4f into hypertrons:master Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants